Re: [Mesa-dev] [PATCH 3/4] gallium: remove pipe_index_buffer and set_index_buffer

2017-05-02 Thread Marek Olšák
Thanks. I'm amending this: diff --git a/src/gallium/state_trackers/nine/device9.c b/src/gallium/state_trackers/nine/device9.c index 5dc24d6..f26552c 100644 --- a/src/gallium/state_trackers/nine/device9.c +++ b/src/gallium/state_trackers/nine/device9.c @@ -2913,6 +2913,7 @@

Re: [Mesa-dev] [PATCH 3/4] gallium: remove pipe_index_buffer and set_index_buffer

2017-04-30 Thread Axel Davy
Hi Marek, Here is probably the second mistake: I guess you should change info.start to take into account the offset of the index buffer. Yours, Axel Davy On 29/04/2017 01:12, Marek Olšák wrote: CSMT_ITEM_NO_WAIT(nine_context_draw_indexed_primitive,

Re: [Mesa-dev] [PATCH 3/4] gallium: remove pipe_index_buffer and set_index_buffer

2017-04-30 Thread Axel Davy
Dear Marek, I'm not sure where is the regression in nine reported by Mike and Edmondo, but here there's a mistake with the handling of the index user buffer case. After your patch, when 'csmt_active' is false, NineDevice9_DrawIndexedPrimitiveUP won't work because you don't upload the data