Re: [Mesa-dev] [PATCH 3/4] i965/vec4: Combine all the math emitters.

2014-11-13 Thread Kenneth Graunke
On Wednesday, November 12, 2014 09:57:30 PM Matt Turner wrote: On Wed, Nov 12, 2014 at 9:35 PM, Kenneth Graunke kenn...@whitecape.org wrote: +vec4_visitor::emit_math(enum opcode opcode, + dst_reg dst, src_reg src0, src_reg src1) I think you can make the arguments

Re: [Mesa-dev] [PATCH 3/4] i965/vec4: Combine all the math emitters.

2014-11-13 Thread Francisco Jerez
Kenneth Graunke kenn...@whitecape.org writes: On Wednesday, November 12, 2014 09:57:30 PM Matt Turner wrote: On Wed, Nov 12, 2014 at 9:35 PM, Kenneth Graunke kenn...@whitecape.org wrote: +vec4_visitor::emit_math(enum opcode opcode, + dst_reg dst, src_reg src0,

Re: [Mesa-dev] [PATCH 3/4] i965/vec4: Combine all the math emitters.

2014-11-13 Thread Kenneth Graunke
On Thursday, November 13, 2014 03:09:22 PM Francisco Jerez wrote: Kenneth Graunke kenn...@whitecape.org writes: On Wednesday, November 12, 2014 09:57:30 PM Matt Turner wrote: On Wed, Nov 12, 2014 at 9:35 PM, Kenneth Graunke kenn...@whitecape.org wrote: +vec4_visitor::emit_math(enum

[Mesa-dev] [PATCH 3/4] i965/vec4: Combine all the math emitters.

2014-11-12 Thread Kenneth Graunke
17 insertions(+), 102 deletions(-). Works just as well. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_vec4.h | 8 +- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 111 - 2 files changed, 17 insertions(+), 102

Re: [Mesa-dev] [PATCH 3/4] i965/vec4: Combine all the math emitters.

2014-11-12 Thread Matt Turner
On Wed, Nov 12, 2014 at 9:35 PM, Kenneth Graunke kenn...@whitecape.org wrote: +vec4_visitor::emit_math(enum opcode opcode, + dst_reg dst, src_reg src0, src_reg src1) I think you can make the arguments const references too? + if (brw-gen == 6 dst.writemask !=