Re: [Mesa-dev] [PATCH 3/4] nvc0: allow a non-user buffer to be bound at position 0

2019-07-26 Thread Karol Herbst
On Fri, Jul 26, 2019 at 2:59 PM Ilia Mirkin wrote: > > Thanks! I had to make a small update to the asserts: > > assert(nvc0->constbuf[5][0].user || !nvc0->constbuf[5][0].u.buf); > > u.buf is not valid to check when .user is set. (in fact it aliases > with the "data" pointer) > > Let me know if you

Re: [Mesa-dev] [PATCH 3/4] nvc0: allow a non-user buffer to be bound at position 0

2019-07-26 Thread Ilia Mirkin
Thanks! I had to make a small update to the asserts: assert(nvc0->constbuf[5][0].user || !nvc0->constbuf[5][0].u.buf); u.buf is not valid to check when .user is set. (in fact it aliases with the "data" pointer) Let me know if you want me to resend. On Fri, Jul 26, 2019 at 5:51 AM Karol Herbst

Re: [Mesa-dev] [PATCH 3/4] nvc0: allow a non-user buffer to be bound at position 0

2019-07-26 Thread Karol Herbst
Reviewed-by: Karol Herbst On Fri, Jul 26, 2019 at 5:31 AM Ilia Mirkin wrote: > > Previously the code only handled it for positions 1 and up (as would be > for UBO's in GL). It's not a lot of trouble to handle this, and vl or > vdpau want this. > > Bugzilla: https://bugs.freedesktop.org/show_bug.

[Mesa-dev] [PATCH 3/4] nvc0: allow a non-user buffer to be bound at position 0

2019-07-25 Thread Ilia Mirkin
Previously the code only handled it for positions 1 and up (as would be for UBO's in GL). It's not a lot of trouble to handle this, and vl or vdpau want this. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111213 Signed-off-by: Ilia Mirkin Cc: mesa-sta...@lists.freedesktop.org --- .../dr