Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 7:54 PM, Lauri Kasanen wrote: > On Wed, 8 Jan 2014 19:03:53 +0100 > Marek Olšák wrote: > >> On Wed, Jan 8, 2014 at 6:21 PM, Lauri Kasanen wrote: >> > On Wed, 8 Jan 2014 15:54:04 +0100 >> > Marek Olšák wrote: >> >> It's not accurate at all, it's actually pretty random. The

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Lauri Kasanen
On Wed, 8 Jan 2014 19:03:53 +0100 Marek Olšák wrote: > On Wed, Jan 8, 2014 at 6:21 PM, Lauri Kasanen wrote: > > On Wed, 8 Jan 2014 15:54:04 +0100 > > Marek Olšák wrote: > >> It's not accurate at all, it's actually pretty random. The stats > >> should not be called "num_reads" and "num_writes",

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 6:38 PM, Lauri Kasanen wrote: > On Wed, 8 Jan 2014 15:56:33 +0200 > Lauri Kasanen wrote: > >> On Wed, 8 Jan 2014 12:03:12 +0100 >> Marek Olšák wrote: >> > Also, last_cpu_time will be wrong anyway, because the driver may call >> > the buffer_map function only once per buffe

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 6:21 PM, Lauri Kasanen wrote: > On Wed, 8 Jan 2014 15:54:04 +0100 > Marek Olšák wrote: > >> > On Wed, 8 Jan 2014 12:03:12 +0100 >> > Marek Olšák wrote: >> >> Why don't you just set the statistics once per CS in >> >> radeon_drm_cs_flush? I don't see a value in doing it in

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Lauri Kasanen
On Wed, 8 Jan 2014 15:56:33 +0200 Lauri Kasanen wrote: > On Wed, 8 Jan 2014 12:03:12 +0100 > Marek Olšák wrote: > > Also, last_cpu_time will be wrong anyway, because the driver may call > > the buffer_map function only once per buffer, e.g. at buffer creation. > > It's not a rule, but it happens

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Lauri Kasanen
On Wed, 8 Jan 2014 15:54:04 +0100 Marek Olšák wrote: > > On Wed, 8 Jan 2014 12:03:12 +0100 > > Marek Olšák wrote: > >> Why don't you just set the statistics once per CS in > >> radeon_drm_cs_flush? I don't see a value in doing it in every function > >> that sets the resources. > > > > It's the o

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Wed, Jan 8, 2014 at 2:56 PM, Lauri Kasanen wrote: > On Wed, 8 Jan 2014 12:03:12 +0100 > Marek Olšák wrote: > >> On Tue, Jan 7, 2014 at 7:14 PM, Lauri Kasanen wrote: >> > These will be used later on for optimizing the VRAM placement. >> > >> > No measurable overhead (glxgears, torcs). >> > >>

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Lauri Kasanen
On Wed, 8 Jan 2014 12:03:12 +0100 Marek Olšák wrote: > On Tue, Jan 7, 2014 at 7:14 PM, Lauri Kasanen wrote: > > These will be used later on for optimizing the VRAM placement. > > > > No measurable overhead (glxgears, torcs). > > > > v2: Get accurate stats by taking dirty_masks into account > >

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-08 Thread Marek Olšák
On Tue, Jan 7, 2014 at 7:14 PM, Lauri Kasanen wrote: > These will be used later on for optimizing the VRAM placement. > > No measurable overhead (glxgears, torcs). > > v2: Get accurate stats by taking dirty_masks into account Why don't you just set the statistics once per CS in radeon_drm_cs_flus

[Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-07 Thread Lauri Kasanen
These will be used later on for optimizing the VRAM placement. No measurable overhead (glxgears, torcs). v2: Get accurate stats by taking dirty_masks into account Marek: I'm not sure I was testing torcs right; I started a race on Forza, drove around, and looked at the fps. Doesn't seem to do ti

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-07 Thread Marek Olšák
On Tue, Jan 7, 2014 at 11:14 AM, Lauri Kasanen wrote: > On Tue, 7 Jan 2014 01:44:28 +0100 > Marek Olšák wrote: > >> On Mon, Jan 6, 2014 at 12:17 PM, Lauri Kasanen wrote: >> > These will be used later on for optimizing the VRAM placement. >> > >> > No measurable overhead (glxgears). >> >> I recom

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-07 Thread Lauri Kasanen
On Tue, 7 Jan 2014 01:44:28 +0100 Marek Olšák wrote: > On Mon, Jan 6, 2014 at 12:17 PM, Lauri Kasanen wrote: > > These will be used later on for optimizing the VRAM placement. > > > > No measurable overhead (glxgears). > > I recommend testing torcs (the Forza track) next time. glxgears is not >

Re: [Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-06 Thread Marek Olšák
On Mon, Jan 6, 2014 at 12:17 PM, Lauri Kasanen wrote: > These will be used later on for optimizing the VRAM placement. > > No measurable overhead (glxgears). I recommend testing torcs (the Forza track) next time. glxgears is not useful here. > > Signed-off-by: Lauri Kasanen > --- > src/gallium

[Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-06 Thread Lauri Kasanen
These will be used later on for optimizing the VRAM placement. No measurable overhead (glxgears). Signed-off-by: Lauri Kasanen --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 +++ src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 16 src/gallium/winsys/radeon/drm/radeon_dr

[Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-03 Thread Lauri Kasanen
These will be used later on for optimizing the VRAM placement. No measurable overhead (glxgears). Signed-off-by: Lauri Kasanen --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 +++ src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 16 src/gallium/winsys/radeon/drm/radeon_dr

[Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-01 Thread Lauri Kasanen
These will be used later on for optimizing the VRAM placement. Currently some glxgears overhead (~7% less), real apps yet to be benched. Signed-off-by: Lauri Kasanen --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 +++ src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 16 s