[Mesa-dev] [PATCH 3/5] glsl: Return error_type instead of NULL if element_type() is called on non array type.

2013-06-03 Thread Fabian Bieler
This matches the behavior of field_type() and other get_*_type() methods. I looked through the calls to element_type() and didn't find a caller that depends on the old behavior. Signed-off-by: Fabian Bieler --- src/glsl/glsl_types.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) d

Re: [Mesa-dev] [PATCH 3/5] glsl: Return error_type instead of NULL if element_type() is called on non array type.

2013-06-18 Thread Ian Romanick
On 06/03/2013 01:23 PM, Fabian Bieler wrote: This matches the behavior of field_type() and other get_*_type() methods. I looked through the calls to element_type() and didn't find a caller that depends on the old behavior. I'm a little be uncomfortable with this change. There are a few places

Re: [Mesa-dev] [PATCH 3/5] glsl: Return error_type instead of NULL if element_type() is called on non array type.

2013-06-18 Thread Fabian Bieler
On 2013-06-18 11:24, Ian Romanick wrote: > On 06/03/2013 01:23 PM, Fabian Bieler wrote: >> This matches the behavior of field_type() and other get_*_type() methods. >> >> I looked through the calls to element_type() and didn't find a caller that >> depends on the old behavior. > > I'm a little be