Re: [Mesa-dev] [PATCH 3/7] glsl: add AoA support to subroutines

2015-10-20 Thread Timothy Arceri
On Wed, 2015-10-21 at 13:28 +1000, Dave Airlie wrote: > On 16 October 2015 at 12:51, Timothy Arceri > wrote: > > On Fri, 2015-10-16 at 11:44 +1000, Dave Airlie wrote: > > > you gotta give me something in the commit msg to have any idea > > > what > > > I'm reading here :-) > > > > > > why does pr

Re: [Mesa-dev] [PATCH 3/7] glsl: add AoA support to subroutines

2015-10-20 Thread Dave Airlie
On 16 October 2015 at 12:51, Timothy Arceri wrote: > On Fri, 2015-10-16 at 11:44 +1000, Dave Airlie wrote: >> you gotta give me something in the commit msg to have any idea what >> I'm reading here :-) >> >> why does process_parameters move? > > Because we need actual_parameters processed earlier

Re: [Mesa-dev] [PATCH 3/7] glsl: add AoA support to subroutines

2015-10-15 Thread Timothy Arceri
On Fri, 2015-10-16 at 11:44 +1000, Dave Airlie wrote: > you gotta give me something in the commit msg to have any idea what > I'm reading here :-) > > why does process_parameters move? Because we need actual_parameters processed earlier so we can use it with match_subroutine_by_name() to get the

Re: [Mesa-dev] [PATCH 3/7] glsl: add AoA support to subroutines

2015-10-15 Thread Dave Airlie
you gotta give me something in the commit msg to have any idea what I'm reading here :-) why does process_parameters move? is there a piglit for subroutine/arrays? Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.

[Mesa-dev] [PATCH 3/7] glsl: add AoA support to subroutines

2015-10-15 Thread Timothy Arceri
Cc: Dave Airlie --- src/glsl/ast_function.cpp | 43 ++- src/glsl/lower_subroutine.cpp | 2 +- 2 files changed, 39 insertions(+), 6 deletions(-) diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp index c5c5cae..e4e4a3f 100644 --- a/src/