[Mesa-dev] [PATCH 3/8] Support of RENDER_TYPE property [3/6] Changes to visual configs initialization.

2013-07-15 Thread Tomasz Lis
The change is to correctly handle the value of renderType and drawableType in fbconfig. This part modifies glXInitializeVisualConfigFromTags to read the parameter value, or detect it if it's not there. --- src/glx/glxext.c | 35 +++ src/mesa/drivers/

Re: [Mesa-dev] [PATCH 3/8] Support of RENDER_TYPE property [3/6] Changes to visual configs initialization.

2013-07-15 Thread Ian Romanick
On 07/15/2013 07:28 AM, Tomasz Lis wrote: The change is to correctly handle the value of renderType and drawableType in fbconfig. This part modifies glXInitializeVisualConfigFromTags to read the parameter value, or detect it if it's not there. --- src/glx/glxext.c | 35 +

Re: [Mesa-dev] [PATCH 3/8] Support of RENDER_TYPE property [3/6] Changes to visual configs initialization.

2013-07-16 Thread Brian Paul
On 07/15/2013 12:33 PM, Ian Romanick wrote: On 07/15/2013 07:28 AM, Tomasz Lis wrote: [...] diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c index 969ee7d..7a2cfbe 100644 --- a/src/mesa/drivers/x11/fakeglx.c +++ b/src/mesa/drivers/x11/fakeglx.c I'm not sure these l

Re: [Mesa-dev] [PATCH 3/8] Support of RENDER_TYPE property [3/6] Changes to visual configs initialization.

2013-07-16 Thread Tomasz Lis
Thank you for your feedback. I will remove GL_TRUE/FALSE and treat these as C logic values. I will change setting of the mutually exclusive flags. While I think using bitwise OR emphases the fact that these are bit flags and not integer values, both ways will work. Please make sure someone will v