Re: [Mesa-dev] [PATCH 3/9] i965: fix 64-bit immediates in brw_inst(_set)_bits

2015-11-19 Thread Kristian Høgsberg
On Thu, Nov 19, 2015 at 11:24 AM, Matt Turner wrote: > On Thu, Nov 19, 2015 at 9:30 AM, Kristian Høgsberg wrote: >> On Thu, Nov 19, 2015 at 2:05 AM, Iago Toral Quiroga >> wrote: >>> From: Connor Abbott >>>

Re: [Mesa-dev] [PATCH 3/9] i965: fix 64-bit immediates in brw_inst(_set)_bits

2015-11-19 Thread Matt Turner
On Thu, Nov 19, 2015 at 11:35 AM, Kristian Høgsberg wrote: > On Thu, Nov 19, 2015 at 11:24 AM, Matt Turner wrote: >> On Thu, Nov 19, 2015 at 9:30 AM, Kristian Høgsberg >> wrote: >>> On Thu, Nov 19, 2015 at 2:05 AM, Iago Toral Quiroga

Re: [Mesa-dev] [PATCH 3/9] i965: fix 64-bit immediates in brw_inst(_set)_bits

2015-11-19 Thread Matt Turner
On Thu, Nov 19, 2015 at 9:30 AM, Kristian Høgsberg wrote: > On Thu, Nov 19, 2015 at 2:05 AM, Iago Toral Quiroga wrote: >> From: Connor Abbott >> >> If we tried to get/set something that was exactly 64 bits, we would >> try to do

Re: [Mesa-dev] [PATCH 3/9] i965: fix 64-bit immediates in brw_inst(_set)_bits

2015-11-19 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/9] i965: fix 64-bit immediates in brw_inst(_set)_bits

2015-11-19 Thread Iago Toral
On Thu, 2015-11-19 at 12:08 -0800, Matt Turner wrote: > On Thu, Nov 19, 2015 at 11:35 AM, Kristian Høgsberg > wrote: > > On Thu, Nov 19, 2015 at 11:24 AM, Matt Turner wrote: > >> On Thu, Nov 19, 2015 at 9:30 AM, Kristian Høgsberg >

Re: [Mesa-dev] [PATCH 3/9] i965: fix 64-bit immediates in brw_inst(_set)_bits

2015-11-19 Thread Kristian Høgsberg
On Thu, Nov 19, 2015 at 2:05 AM, Iago Toral Quiroga wrote: > From: Connor Abbott > > If we tried to get/set something that was exactly 64 bits, we would > try to do (1 << 64) - 1 to calculate the mask which doesn't give us all > 1's like we want. > >

Re: [Mesa-dev] [PATCH 3/9] i965: fix 64-bit immediates in brw_inst(_set)_bits

2015-11-19 Thread Ilia Mirkin
On Thu, Nov 19, 2015 at 12:30 PM, Kristian Høgsberg wrote: > On Thu, Nov 19, 2015 at 2:05 AM, Iago Toral Quiroga wrote: >> From: Connor Abbott >> >> If we tried to get/set something that was exactly 64 bits, we would >> try to do