Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

2016-07-25 Thread Rob Clark
On Mon, Jul 25, 2016 at 1:19 PM, Marek Olšák wrote: > On Mon, Jul 25, 2016 at 5:42 PM, Rob Clark wrote: >> On Mon, Jul 25, 2016 at 11:16 AM, Brian Paul wrote: >>> On 07/18/2016 07:11 AM, Marek Olšák wrote: @@ -183,49 +107,42 @@

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

2016-07-25 Thread Marek Olšák
On Mon, Jul 25, 2016 at 5:42 PM, Rob Clark wrote: > On Mon, Jul 25, 2016 at 11:16 AM, Brian Paul wrote: >> On 07/18/2016 07:11 AM, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> The goal is to do this in st_validate_state: >>>

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

2016-07-25 Thread Rob Clark
On Mon, Jul 25, 2016 at 11:16 AM, Brian Paul wrote: > On 07/18/2016 07:11 AM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> The goal is to do this in st_validate_state: >> while (dirty) >>atoms[u_bit_scan()]->update(st); >> >> That implies

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

2016-07-25 Thread Brian Paul
On 07/18/2016 07:11 AM, Marek Olšák wrote: From: Marek Olšák The goal is to do this in st_validate_state: while (dirty) atoms[u_bit_scan()]->update(st); That implies that atoms can't specify which flags they consume. There is exactly one ST_NEW_* flag for each

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

2016-07-19 Thread Rob Clark
() On Mon, Jul 18, 2016 at 9:11 AM, Marek Olšák wrote: > From: Marek Olšák > > The goal is to do this in st_validate_state: >while (dirty) > atoms[u_bit_scan()]->update(st); > > That implies that atoms can't specify which flags they consume. >

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

2016-07-18 Thread Eero Tamminen
Hi, On 18.07.2016 16:11, Marek Olšák wrote: torcs is 2% faster between the previous patch and the end of this series. "Driver" & "Driver2" tests included with GFXBench v4 could be good to check with this. They're fully CPU bound, synthetic 3D driver tests doing subset of stuff that the

Re: [Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

2016-07-18 Thread Emil Velikov
On 18 July 2016 at 14:11, Marek Olšák wrote: > From: Marek Olšák > > The goal is to do this in st_validate_state: >while (dirty) > atoms[u_bit_scan()]->update(st); > > That implies that atoms can't specify which flags they consume. > There is

[Mesa-dev] [PATCH 3/9] st/mesa: completely rewrite state atoms

2016-07-18 Thread Marek Olšák
From: Marek Olšák The goal is to do this in st_validate_state: while (dirty) atoms[u_bit_scan()]->update(st); That implies that atoms can't specify which flags they consume. There is exactly one ST_NEW_* flag for each atom. (58 flags in total) There are macros