Re: [Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

2016-05-04 Thread Iago Toral
On Mon, 2016-05-02 at 11:38 +0300, Pohjolainen, Topi wrote: > On Fri, Apr 29, 2016 at 01:29:29PM +0200, Samuel Iglesias Gons?lvez wrote: > > From: Iago Toral Quiroga > > > > When we are actually unpacking from a double that we have previously > > packed from its 32-bit components we can bypass th

Re: [Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

2016-05-03 Thread Pohjolainen, Topi
On Tue, May 03, 2016 at 09:35:42AM +0200, Samuel Iglesias Gons?lvez wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 02/05/16 10:38, Pohjolainen, Topi wrote: > > On Fri, Apr 29, 2016 at 01:29:29PM +0200, Samuel Iglesias Gons?lvez > > wrote: > >> From: Iago Toral Quiroga > >

Re: [Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

2016-05-03 Thread Samuel Iglesias Gonsálvez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 02/05/16 10:38, Pohjolainen, Topi wrote: > On Fri, Apr 29, 2016 at 01:29:29PM +0200, Samuel Iglesias Gons?lvez > wrote: >> From: Iago Toral Quiroga >> >> When we are actually unpacking from a double that we have >> previously packed from its 3

Re: [Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

2016-05-02 Thread Connor Abbott
Same comment about missing the check for a non-SSA source. On Fri, Apr 29, 2016 at 7:29 AM, Samuel Iglesias Gonsálvez wrote: > From: Iago Toral Quiroga > > When we are actually unpacking from a double that we have previously > packed from its 32-bit components we can bypass the pack operation >

Re: [Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

2016-05-02 Thread Pohjolainen, Topi
On Fri, Apr 29, 2016 at 01:29:29PM +0200, Samuel Iglesias Gons?lvez wrote: > From: Iago Toral Quiroga > > When we are actually unpacking from a double that we have previously > packed from its 32-bit components we can bypass the pack operation > and source from its arguments directly. > --- > sr

[Mesa-dev] [PATCH 32/59] i965/fs: optimize unpack double

2016-04-29 Thread Samuel Iglesias Gonsálvez
From: Iago Toral Quiroga When we are actually unpacking from a double that we have previously packed from its 32-bit components we can bypass the pack operation and source from its arguments directly. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 28 1 file changed,