Re: [Mesa-dev] [PATCH 4/4] glsl/linker: outputs in the same location must share auxiliary storage

2017-10-19 Thread Iago Toral
On Fri, 2017-10-20 at 15:06 +1100, Timothy Arceri wrote: > I only really skimmed over them but these look fine to me 3-4: > > Reviewed-by: Timothy Arceri > > Thanks! > Thanks for the reviews Timothy. Illia: do you have any plans to work on the SSO path? if not, I am happy to try and fix that

Re: [Mesa-dev] [PATCH 4/4] glsl/linker: outputs in the same location must share auxiliary storage

2017-10-19 Thread Timothy Arceri
I only really skimmed over them but these look fine to me 3-4: Reviewed-by: Timothy Arceri Thanks! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 4/4] glsl/linker: outputs in the same location must share auxiliary storage

2017-10-19 Thread Iago Toral Quiroga
From ARB_enhanced_layouts: "[...]when location aliasing, the aliases sharing the location must have the same underlying numerical type (floating-point or integer) and the same auxiliary storage and interpolation qualification.[...]" Add code to the linker to validate that aliased locations