Re: [Mesa-dev] [PATCH 4/4] glx: fix error code when there is no context bound

2016-02-28 Thread Tapani Pälli
On 02/22/2016 10:16 PM, Ian Romanick wrote: There are 17 total occurrences of grep -r '[(]!gc[)]' src/glx/ and grep -r 'gc[[:space:]]*==[[:space:]]*NULL' src/glx/ None of these check for dummyContext. This is all very suspicious. Looking at the implementation(s) of __glXGetCurrent

Re: [Mesa-dev] [PATCH 4/4] glx: fix error code when there is no context bound

2016-02-22 Thread Ian Romanick
There are 17 total occurrences of grep -r '[(]!gc[)]' src/glx/ and grep -r 'gc[[:space:]]*==[[:space:]]*NULL' src/glx/ None of these check for dummyContext. This is all very suspicious. Looking at the implementation(s) of __glXGetCurrentContext, I don't think it can ever return NULL.

[Mesa-dev] [PATCH 4/4] glx: fix error code when there is no context bound

2016-02-11 Thread Tapani Pälli
From: Bernard Kilarski Signed-off-by: Bernard Kilarski Signed-off-by: Matt Roper Cc: "11.0 11.1" psc, attribute, value); @@ -166,7 +166,7 @@ glXQueryCurrentRendererStringMESA(int attribute) { struct glx_context *gc = __glXGetCurrentContext(); - if (gc == NULL) + if (gc == NULL || gc