Re: [Mesa-dev] [PATCH 4/4] nir: reorder some code

2019-02-13 Thread Timothy Arceri
On 14/2/19 1:44 am, Jason Ekstrand wrote: I'm not sure that I think about this one. I kind of like the pattern where the first thing in the switch case on subtype is a cast to that subtype. It's also just a cast in debug builds so it should generate zero code. Callgrind did show a change but

Re: [Mesa-dev] [PATCH 4/4] nir: reorder some code

2019-02-13 Thread Jason Ekstrand
I'm not sure that I think about this one. I kind of like the pattern where the first thing in the switch case on subtype is a cast to that subtype. It's also just a cast in debug builds so it should generate zero code. On February 13, 2019 02:00:49 Timothy Arceri wrote: The compile shoud do

[Mesa-dev] [PATCH 4/4] nir: reorder some code

2019-02-13 Thread Timothy Arceri
The compile shoud do this for us so this is more for neatness rather than speed. --- src/compiler/nir/nir_search.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/compiler/nir/nir_search.c b/src/compiler/nir/nir_search.c index d257b639189..f0a79a54301 100644 --- a/src/com