Re: [Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

2017-04-26 Thread Marek Olšák
For dual source blending, CB_COLOR1_INFO is required to be the same as CB_COLOR0_INFO. Other than that, as long as there are no piglit regressions, I'm OK with any development going on in gallium/drivers/r600. If you want me to commit stuff, please send me a pull request or you can ask for an

Re: [Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

2017-04-25 Thread Dieter Nützel
This one is Tested-by: Dieter Nützel My gut feeling is 'faster than ever'! Even WebGL (Konqi 5.0.97) apps (HD 1920x1080) are very smooth, now. Marek can you comment and then commit? Dieter Am 25.04.2017 13:59, schrieb Constantine Kharlamov: It finishes the work

Re: [Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

2017-04-25 Thread Constantine Kharlamov
On 25.04.2017 14:59, Constantine Kharlamov wrote: > It finishes the work started by 0c2eed0edec, quoting: > >> The main idea is to avoid setting CB_COLORi_INFO = 0 for i>0 repeatedly >> when those colorbuffers aren't used. This is mainly for glamor. > > After 0c2eed0edec the r600g was passing

[Mesa-dev] [PATCH 4/4] r600g: avoid redundant CB updates

2017-04-25 Thread Constantine Kharlamov
It finishes the work started by 0c2eed0edec, quoting: > The main idea is to avoid setting CB_COLORi_INFO = 0 for i>0 repeatedly > when those colorbuffers aren't used. This is mainly for glamor. After 0c2eed0edec the r600g was passing null as the dirty_cbufs pointer, and the current patch makes