Re: [Mesa-dev] [PATCH 4/5] radv: implement VK_KHR_descriptor_update_template

2017-04-06 Thread Fredrik Höglund
On Wednesday 05 April 2017, Bas Nieuwenhuizen wrote: > Could you move the declarations you add in radv_descriptor_set.h to > radv_private.h? I'd like to keep it limited to whatever is necessary > for the compiler, which is only the set & pipeline layouts. You could > just put it next to the

Re: [Mesa-dev] [PATCH 4/5] radv: implement VK_KHR_descriptor_update_template

2017-04-04 Thread Bas Nieuwenhuizen
Could you move the declarations you add in radv_descriptor_set.h to radv_private.h? I'd like to keep it limited to whatever is necessary for the compiler, which is only the set & pipeline layouts. You could just put it next to the radv_descriptor_set declaration. Otherwise, nice work! The series

[Mesa-dev] [PATCH 4/5] radv: implement VK_KHR_descriptor_update_template

2017-04-04 Thread Fredrik Höglund
All offsets and strides are precomputed by radv_CreateDescriptorUpdateTemplateKHR and stored in the template. Signed-off-by: Fredrik Höglund --- src/amd/vulkan/radv_cmd_buffer.c | 24 + src/amd/vulkan/radv_descriptor_set.c | 163 +