Re: [Mesa-dev] [PATCH 4/6] ac/nir: rewrite shared variable handling

2017-07-06 Thread Bas Nieuwenhuizen
Patches 3-4 look technically correct to me, so for just using it for shared vars Reviewed-by: Bas Nieuwenhuizen On Thu, Jul 6, 2017 at 9:48 PM, Connor Abbott wrote: > From: Connor Abbott > > Similar to before, do the direct NIR->LLVM translation instead of > lowering to an array then back to a

[Mesa-dev] [PATCH 4/6] ac/nir: rewrite shared variable handling

2017-07-06 Thread Connor Abbott
From: Connor Abbott Similar to before, do the direct NIR->LLVM translation instead of lowering to an array then back to a variable. This should fix indirect dereferences, make shared variables more tightly packed, and make LLVM's alias analysis more precise. --- src/amd/common/ac_nir_to_llvm.c |