Re: [Mesa-dev] [PATCH 4/6] nir: Add a local variable-based copy propagation pass

2017-01-05 Thread Jason Ekstrand
On Wed, Jan 4, 2017 at 9:31 PM, Timothy Arceri wrote: > There was a bit to take in here but it seems ok to me. I've made a > bunch of trivial suggestions/comments below otherwise: > > Reviewed-by: Timothy Arceri > > On Mon, 2016-12-12

Re: [Mesa-dev] [PATCH 4/6] nir: Add a local variable-based copy propagation pass

2017-01-04 Thread Timothy Arceri
There was a bit to take in here but it seems ok to me. I've made a bunch of trivial suggestions/comments below otherwise: Reviewed-by: Timothy Arceri On Mon, 2016-12-12 at 19:39 -0800, Jason Ekstrand wrote: > --- >  src/compiler/Makefile.sources |   1

Re: [Mesa-dev] [PATCH 4/6] nir: Add a local variable-based copy propagation pass

2017-01-04 Thread Jason Ekstrand
Ping? On Dec 12, 2016 21:39, "Jason Ekstrand" wrote: > --- > src/compiler/Makefile.sources | 1 + > src/compiler/nir/nir.h| 2 + > src/compiler/nir/nir_opt_copy_prop_vars.c | 799 > ++ > 3 files changed, 802

Re: [Mesa-dev] [PATCH 4/6] nir: Add a local variable-based copy propagation pass

2016-12-13 Thread Jason Ekstrand
On Tue, Dec 13, 2016 at 9:43 AM, Eric Anholt wrote: > Jason Ekstrand writes: > > > diff --git a/src/compiler/nir/nir_opt_copy_prop_vars.c > b/src/compiler/nir/nir_opt_copy_prop_vars.c > > new file mode 100644 > > index 000..728e476 > > --- /dev/null >

Re: [Mesa-dev] [PATCH 4/6] nir: Add a local variable-based copy propagation pass

2016-12-13 Thread Eric Anholt
Jason Ekstrand writes: > diff --git a/src/compiler/nir/nir_opt_copy_prop_vars.c > b/src/compiler/nir/nir_opt_copy_prop_vars.c > new file mode 100644 > index 000..728e476 > --- /dev/null > +++ b/src/compiler/nir/nir_opt_copy_prop_vars.c > @@ -0,0 +1,799 @@ > +/* > + *

[Mesa-dev] [PATCH 4/6] nir: Add a local variable-based copy propagation pass

2016-12-12 Thread Jason Ekstrand
--- src/compiler/Makefile.sources | 1 + src/compiler/nir/nir.h| 2 + src/compiler/nir/nir_opt_copy_prop_vars.c | 799 ++ 3 files changed, 802 insertions(+) create mode 100644 src/compiler/nir/nir_opt_copy_prop_vars.c diff --git