Re: [Mesa-dev] [PATCH 4/7] helper-conveniance functions for drivers to implement ARB_framebuffer_no_attachment

2015-04-28 Thread Rogovin, Kevin
Hi, This is in fact two changes: introduction of the helpers and refactoring of the intersection code to be used with caller provided bounding box. Is this a request to change the commit message or to split this as well? I think splitting it is silly, but if it make you happy so be it; the

Re: [Mesa-dev] [PATCH 4/7] helper-conveniance functions for drivers to implement ARB_framebuffer_no_attachment

2015-04-28 Thread Pohjolainen, Topi
On Fri, Apr 24, 2015 at 09:59:07AM +0300, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com To assist drivers to implement ARB_framebuffer_no_attachment, provide a set of convenience functions that check for gl_framebuffer::_HasAttachments that return the geometry of

[Mesa-dev] [PATCH 4/7] helper-conveniance functions for drivers to implement ARB_framebuffer_no_attachment

2015-04-24 Thread kevin . rogovin
From: Kevin Rogovin kevin.rogo...@intel.com To assist drivers to implement ARB_framebuffer_no_attachment, provide a set of convenience functions that check for gl_framebuffer::_HasAttachments that return the geometry of the gl_framebuffer. --- src/mesa/main/framebuffer.c | 49

Re: [Mesa-dev] [PATCH 4/7] helper-conveniance functions for drivers to implement ARB_framebuffer_no_attachment

2015-04-24 Thread Tapani Pälli
Functionally correct, style nitpicks below, with those fixed; Reviewed-by: Tapani Pälli tapani.pa...@intel.com On 04/24/2015 09:59 AM, kevin.rogo...@intel.com wrote: From: Kevin Rogovin kevin.rogo...@intel.com To assist drivers to implement ARB_framebuffer_no_attachment, provide a set of