[Mesa-dev] [PATCH 4/8] nir: Pass a type_size() function pointer into nir_lower_io().

2015-08-17 Thread Kenneth Graunke
Previously, there were four type_size() functions in play - the i965 compiler backend defined scalar and vec4 type_size() functions, and nir_lower_io contained its own similar functions. In fact, the i965 driver used nir_lower_io() and then looped over the components using its own type_size - mean

Re: [Mesa-dev] [PATCH 4/8] nir: Pass a type_size() function pointer into nir_lower_io().

2015-08-17 Thread Jason Ekstrand
The first four are Reviewed-by: Jason Ekstrand I'll get to the others later. On Mon, Aug 17, 2015 at 4:07 PM, Kenneth Graunke wrote: > Previously, there were four type_size() functions in play - the i965 > compiler backend defined scalar and vec4 type_size() functions, and > nir_lower_io conta

Re: [Mesa-dev] [PATCH 4/8] nir: Pass a type_size() function pointer into nir_lower_io().

2015-08-18 Thread Jason Ekstrand
On Mon, Aug 17, 2015 at 4:44 PM, Jason Ekstrand wrote: > The first four are > > Reviewed-by: Jason Ekstrand Before you push any of these, this patch (number 4) breaks image_load_store in a kind-of obscure way. I just sent a patch to fix it up. That patch needs to be applied before this one. >