Re: [Mesa-dev] [PATCH 40/40] r600/radeonsi: enable glsl/tgsi on-disk cache

You might also just create the cache unconditionally in screen_create. Marek On Feb 10, 2017 12:58 PM, "Timothy Arceri" wrote: > > > On 10/02/17 22:25, Marek Olšák wrote: > >> I don't see anything radeonsi-specific here. Is there any reason this >> has to be in

Re: [Mesa-dev] [PATCH 40/40] r600/radeonsi: enable glsl/tgsi on-disk cache

On 10/02/17 22:25, Marek Olšák wrote: I don't see anything radeonsi-specific here. Is there any reason this has to be in radeonsi? disk_cache_create(r600_get_chip_name(rscreen), mesa_version); Is the only AMD specific bit. I did have just have a generic get_gpu_name() function at one

Re: [Mesa-dev] [PATCH 40/40] r600/radeonsi: enable glsl/tgsi on-disk cache

I don't see anything radeonsi-specific here. Is there any reason this has to be in radeonsi? Also, all pipe_screen functions must be thread-safe, so a mutex around checking and setting disk_shader_cache should be used. if _mesa_create_cache_version_string was in src/util, you wouldn't have to

[Mesa-dev] [PATCH 40/40] r600/radeonsi: enable glsl/tgsi on-disk cache

--- src/gallium/drivers/radeon/r600_pipe_common.c | 17 + src/gallium/drivers/radeon/r600_pipe_common.h | 2 ++ src/gallium/include/pipe/p_screen.h | 3 +++ src/mesa/state_tracker/st_context.c | 6 ++ 4 files changed, 28 insertions(+) diff --git