Re: [Mesa-dev] [PATCH 5/5] glsl: Don't do constant propagation in opt_constant_folding.

2016-05-09 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 05/09/2016 08:50 AM, Kenneth Graunke wrote: > opt_constant_folding is supposed to fold trees of constants into a > single constant. Surprisingly, it was also propagating constant values > from variables into expression trees - even when the result coul

[Mesa-dev] [PATCH 5/5] glsl: Don't do constant propagation in opt_constant_folding.

2016-05-08 Thread Kenneth Graunke
opt_constant_folding is supposed to fold trees of constants into a single constant. Surprisingly, it was also propagating constant values from variables into expression trees - even when the result couldn't be folded together. This is opt_constant_propagation's job. The ir_dereference_variable::