Re: [Mesa-dev] [PATCH 5/5] panfrost: Print errors from kernel

2019-08-06 Thread Alyssa Rosenzweig
Alright, you win ;) R-b! On Tue, Aug 06, 2019 at 05:06:32PM +0200, Tomeu Vizoso wrote: > On Tue, 6 Aug 2019 at 16:58, Alyssa Rosenzweig wrote: > > > > > Android should be fine, as they use it in their own code. > > > > Hmm, still uncomfortable, but tentative R-b I guess :/ > > > > I just.. don

Re: [Mesa-dev] [PATCH 5/5] panfrost: Print errors from kernel

2019-08-06 Thread Tomeu Vizoso
On Tue, 6 Aug 2019 at 16:58, Alyssa Rosenzweig wrote: > > > Android should be fine, as they use it in their own code. > > Hmm, still uncomfortable, but tentative R-b I guess :/ > > I just.. don't like relying on glibc specific behaviour. Even if bionic > implements it too, I mean... what happe

Re: [Mesa-dev] [PATCH 5/5] panfrost: Print errors from kernel

2019-08-06 Thread Alyssa Rosenzweig
> Android should be fine, as they use it in their own code. Hmm, still uncomfortable, but tentative R-b I guess :/ I just.. don't like relying on glibc specific behaviour. Even if bionic implements it too, I mean... what happens for the postmarketOS guys? They've been interested in Panfrost f

Re: [Mesa-dev] [PATCH 5/5] panfrost: Print errors from kernel

2019-08-06 Thread Tomeu Vizoso
On Mon, 5 Aug 2019 at 19:06, Alyssa Rosenzweig wrote: > > I didn't know about %m, nifty. > > I don't think this is portable, though... which might be a problem > if/when someone tries to port Android, etc. Android should be fine, as they use it in their own code. Cheers, Tomeu > > On Mon, Aug

Re: [Mesa-dev] [PATCH 5/5] panfrost: Print errors from kernel

2019-08-05 Thread Alyssa Rosenzweig
I didn't know about %m, nifty. I don't think this is portable, though... which might be a problem if/when someone tries to port Android, etc. On Mon, Aug 05, 2019 at 05:18:36PM +0200, Tomeu Vizoso wrote: > Signed-off-by: Tomeu Vizoso > --- > src/gallium/drivers/panfrost/pan_drm.c | 10 +

[Mesa-dev] [PATCH 5/5] panfrost: Print errors from kernel

2019-08-05 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- src/gallium/drivers/panfrost/pan_drm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c index 122bc5f3db36..46cceb808919 100644 --- a/src/gallium/drivers/