Re: [Mesa-dev] [PATCH 5/6] radv: reorder and add passes to match i965

2017-07-06 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jul 6, 2017 at 9:50 PM, Connor Abbott wrote: > From: Connor Abbott > > This makes the radv shader pipeline much closer to brw_preprocess_nir(). > The main changes are: > > - Now we call nir_split_var_copies(), which is necessary for > nir_lower_var_copies(

[Mesa-dev] [PATCH 5/6] radv: reorder and add passes to match i965

2017-07-06 Thread Connor Abbott
From: Connor Abbott This makes the radv shader pipeline much closer to brw_preprocess_nir(). The main changes are: - Now we call nir_split_var_copies(), which is necessary for nir_lower_var_copies() to work correctly. The SPIR-V frontend never generates variable copies, so we didn't notice this,