Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Matt Turner
On Mon, Aug 3, 2015 at 4:17 PM, Roland Scheidegger wrote: > Reviewed-by: Roland Scheidegger Thanks! > I'm wondering though if this is really exactly implementing lrintf why > we're using a different name and not just something like _mesa_lrintf(). > Though arguably _mesa_roundeven is the same..

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Roland Scheidegger
Am 03.08.2015 um 18:43 schrieb Matt Turner: > gcc actually generates this for us now that we use -fno-math-errno > (which is weird, since lrintf()/lrint() don't set errno) but clang still > does not. Presumably helps MSVC as well. > > Reduced .text size by 8.5k with gcc before -fno-math-errno. >

[Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Matt Turner
gcc actually generates this for us now that we use -fno-math-errno (which is weird, since lrintf()/lrint() don't set errno) but clang still does not. Presumably helps MSVC as well. Reduced .text size by 8.5k with gcc before -fno-math-errno. text data bss dec hex filename 49

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-08-03 Thread Matt Turner
On Fri, Jul 31, 2015 at 6:37 PM, Roland Scheidegger wrote: > Am 01.08.2015 um 03:02 schrieb Matt Turner: >> On Fri, Jul 31, 2015 at 5:50 PM, Roland Scheidegger >> wrote: >>> Am 01.08.2015 um 01:26 schrieb Matt Turner: gcc actually generates this for us now that we use -fno-math-errno (

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-07-31 Thread Roland Scheidegger
Am 01.08.2015 um 03:02 schrieb Matt Turner: > On Fri, Jul 31, 2015 at 5:50 PM, Roland Scheidegger > wrote: >> Am 01.08.2015 um 01:26 schrieb Matt Turner: >>> gcc actually generates this for us now that we use -fno-math-errno >>> (which is weird, since lrintf()/lrint() don't set errno) but clang s

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-07-31 Thread Matt Turner
On Fri, Jul 31, 2015 at 5:50 PM, Roland Scheidegger wrote: > Am 01.08.2015 um 01:26 schrieb Matt Turner: >> gcc actually generates this for us now that we use -fno-math-errno >> (which is weird, since lrintf()/lrint() don't set errno) but clang still >> does not. Presumably helps MSVC as well. >>

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-07-31 Thread Roland Scheidegger
Am 01.08.2015 um 02:44 schrieb Matt Turner: > On Fri, Jul 31, 2015 at 4:41 PM, Ilia Mirkin wrote: >> On Fri, Jul 31, 2015 at 7:26 PM, Matt Turner wrote: >>> gcc actually generates this for us now that we use -fno-math-errno >>> (which is weird, since lrintf()/lrint() don't set errno) but clang st

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-07-31 Thread Roland Scheidegger
Am 01.08.2015 um 01:26 schrieb Matt Turner: > gcc actually generates this for us now that we use -fno-math-errno > (which is weird, since lrintf()/lrint() don't set errno) but clang still > does not. Presumably helps MSVC as well. > > Reduced .text size by 8.5k with gcc before -fno-math-errno. >

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-07-31 Thread Matt Turner
On Fri, Jul 31, 2015 at 4:41 PM, Ilia Mirkin wrote: > On Fri, Jul 31, 2015 at 7:26 PM, Matt Turner wrote: >> gcc actually generates this for us now that we use -fno-math-errno >> (which is weird, since lrintf()/lrint() don't set errno) but clang still >> does not. Presumably helps MSVC as well. >

Re: [Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-07-31 Thread Ilia Mirkin
On Fri, Jul 31, 2015 at 7:26 PM, Matt Turner wrote: > gcc actually generates this for us now that we use -fno-math-errno > (which is weird, since lrintf()/lrint() don't set errno) but clang still > does not. Presumably helps MSVC as well. > > Reduced .text size by 8.5k with gcc before -fno-math-er

[Mesa-dev] [PATCH 5/7] util: Use SSE intrinsics in _mesa_lroundeven{f, }.

2015-07-31 Thread Matt Turner
gcc actually generates this for us now that we use -fno-math-errno (which is weird, since lrintf()/lrint() don't set errno) but clang still does not. Presumably helps MSVC as well. Reduced .text size by 8.5k with gcc before -fno-math-errno. text data bss dec hex filename 49