Re: [Mesa-dev] [PATCH 5/7] vulkan: add VK_EXT_display_control [v5]

2018-06-20 Thread Keith Packard
Jason Ekstrand writes: > That seems good to me. Unless, of course, DPMS is something we expect to > change over time somehow. Then again, we don't handle that at all right > now so meh. Let's go with what you wrote above for now. It's not even the dpms value, it's the dpms property itself, wh

Re: [Mesa-dev] [PATCH 5/7] vulkan: add VK_EXT_display_control [v5]

2018-06-20 Thread Jason Ekstrand
On Tue, Jun 19, 2018 at 9:44 PM, Keith Packard wrote: > Jason Ekstrand writes: > > > >> + if (!prop) > >> + continue; > >> + if (prop->flags & DRM_MODE_PROP_ENUM) { > >> + if (!strcmp(prop->name, "DPMS")) > >> +connector->dpms_property = drm_connector->props

Re: [Mesa-dev] [PATCH 5/7] vulkan: add VK_EXT_display_control [v5]

2018-06-19 Thread Keith Packard
Jason Ekstrand writes: >> + if (!prop) >> + continue; >> + if (prop->flags & DRM_MODE_PROP_ENUM) { >> + if (!strcmp(prop->name, "DPMS")) >> +connector->dpms_property = drm_connector->props[p]; >> > > break? Not break; I need to free the property. However, a

Re: [Mesa-dev] [PATCH 5/7] vulkan: add VK_EXT_display_control [v5]

2018-06-19 Thread Jason Ekstrand
Sorry for the flood of comments. Most of it's pretty trivial. The one that has me the most concerned is the random appearence of 0.1s in some strange places. Other than that, I'm reasonably happy with it. On Thu, Jun 14, 2018 at 7:52 PM, Keith Packard wrote: > This extension provides fences a

[Mesa-dev] [PATCH 5/7] vulkan: add VK_EXT_display_control [v5]

2018-06-14 Thread Keith Packard
This extension provides fences and frame count information to direct display contexts. It uses new kernel ioctls to provide 64-bits of vblank sequence and nanosecond resolution. v2: Remove DRM_CRTC_SEQUENCE_FIRST_PIXEL_OUT flag. This has been removed from the proposed kernel API. Add NULL