Re: [Mesa-dev] [PATCH 5/9] i965: Implement NIR intrinsics for loading VS system values.

2015-03-11 Thread Jason Ekstrand
I'm not terribly happy with how this worked out, I'm not going to NAK it as I think it's the best we can do at the moment. The reason why Connor (and others) have chosen to emit these things at the top of the shader is because they frequently require some computation and we don't want to

Re: [Mesa-dev] [PATCH 5/9] i965: Implement NIR intrinsics for loading VS system values.

2015-03-11 Thread Kenneth Graunke
On Wednesday, March 11, 2015 03:33:24 PM Jason Ekstrand wrote: I'm not terribly happy with how this worked out, I'm not going to NAK it as I think it's the best we can do at the moment. The reason why Connor (and others) have chosen to emit these things at the top of the shader is because

Re: [Mesa-dev] [PATCH 5/9] i965: Implement NIR intrinsics for loading VS system values.

2015-03-11 Thread Jason Ekstrand
On Wed, Mar 11, 2015 at 5:13 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Wednesday, March 11, 2015 03:33:24 PM Jason Ekstrand wrote: I'm not terribly happy with how this worked out, I'm not going to NAK it as I think it's the best we can do at the moment. The reason why Connor

[Mesa-dev] [PATCH 5/9] i965: Implement NIR intrinsics for loading VS system values.

2015-03-09 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 51 1 file changed, 51 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index c5ed55c..d700523