Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

2016-05-05 Thread Samuel Iglesias Gonsálvez
On 03/05/16 01:10, Kenneth Graunke wrote: > On Friday, April 29, 2016 1:29:53 PM PDT Samuel Iglesias Gonsálvez wrote: >> When there is a mix of definitions of uniforms with 32-bit or 64-bit >> data type sizes, the driver ends up doing misaligned access to double >> based variables in the push

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

2016-05-02 Thread Kenneth Graunke
On Monday, May 2, 2016 4:10:38 PM PDT Kenneth Graunke wrote: > The idea of "upload all the 64-bit things first, add 0 or 1 padding > slots, then upload all the 32-bit things" also seems like it could > simplify this code a lot. Sorry, I misspoke - if you upload all the 64-bit things first, then

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

2016-05-02 Thread Kenneth Graunke
On Friday, April 29, 2016 1:29:53 PM PDT Samuel Iglesias Gonsálvez wrote: > When there is a mix of definitions of uniforms with 32-bit or 64-bit > data type sizes, the driver ends up doing misaligned access to double > based variables in the push constant buffer. > > To fix this, the driver adds

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

2016-05-02 Thread Pohjolainen, Topi
On Mon, May 02, 2016 at 04:28:18PM +0300, Pohjolainen, Topi wrote: > On Fri, Apr 29, 2016 at 01:29:53PM +0200, Samuel Iglesias Gons?lvez wrote: > > When there is a mix of definitions of uniforms with 32-bit or 64-bit > > data type sizes, the driver ends up doing misaligned access to double > >

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

2016-05-02 Thread Pohjolainen, Topi
On Fri, Apr 29, 2016 at 01:29:53PM +0200, Samuel Iglesias Gons?lvez wrote: > When there is a mix of definitions of uniforms with 32-bit or 64-bit > data type sizes, the driver ends up doing misaligned access to double > based variables in the push constant buffer. > > To fix this, the driver adds

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

2016-05-02 Thread Pohjolainen, Topi
On Sun, May 01, 2016 at 07:42:42PM -0700, Jordan Justen wrote: > On 2016-04-29 04:29:53, Samuel Iglesias Gonsálvez wrote: > > When there is a mix of definitions of uniforms with 32-bit or 64-bit > > data type sizes, the driver ends up doing misaligned access to double > > based variables in the

Re: [Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

2016-05-01 Thread Jordan Justen
On 2016-04-29 04:29:53, Samuel Iglesias Gonsálvez wrote: > When there is a mix of definitions of uniforms with 32-bit or 64-bit > data type sizes, the driver ends up doing misaligned access to double > based variables in the push constant buffer. > > To fix this, the driver adds padding when

[Mesa-dev] [PATCH 56/59] i965/fs: align access to double-based uniforms in push constant buffer

2016-04-29 Thread Samuel Iglesias Gonsálvez
When there is a mix of definitions of uniforms with 32-bit or 64-bit data type sizes, the driver ends up doing misaligned access to double based variables in the push constant buffer. To fix this, the driver adds padding when needed in the push constant buffer and takes it into account to avoid