Re: [Mesa-dev] [PATCH 6/6] glsl: Don't constant propagate arrays.

2016-06-21 Thread Timothy Arceri
Patches 3-6 are: Reviewed-by: Timothy Arceri On Tue, 2016-06-21 at 20:02 -0700, Kenneth Graunke wrote: > Constant propagation on arrays doesn't make a lot of sense.  If the > array is only accessed with constant indexes, then > opt_array_splitting > would split it up.  Otherwise, we have variabl

[Mesa-dev] [PATCH 6/6] glsl: Don't constant propagate arrays.

2016-06-21 Thread Kenneth Graunke
Constant propagation on arrays doesn't make a lot of sense. If the array is only accessed with constant indexes, then opt_array_splitting would split it up. Otherwise, we have variable indexing. If there's multiple accesses, then constant propagation would end up replicating the data. The lower