[Mesa-dev] [PATCH 6/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

2015-10-02 Thread Samuel Iglesias Gonsalvez
It doesn't round up to vec4 size. Fixes 15 dEQP tests: dEQP-GLES31.functional.ssbo.layout.single_basic_type.std430.row_major_lowp_mat2 dEQP-GLES31.functional.ssbo.layout.single_basic_type.std430.row_major_mediump_mat2

Re: [Mesa-dev] [PATCH 6/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

2015-10-02 Thread Ilia Mirkin
I'm a little concerned that your random ssbo packing tests didn't pick this up... can you double-check your script? On Fri, Oct 2, 2015 at 3:13 AM, Samuel Iglesias Gonsalvez wrote: > It doesn't round up to vec4 size. > > Fixes 15 dEQP tests: > >

Re: [Mesa-dev] [PATCH 6/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

2015-10-02 Thread Samuel Iglesias Gonsálvez
On 02/10/15 09:20, Ilia Mirkin wrote: > I'm a little concerned that your random ssbo packing tests didn't pick > this up... can you double-check your script? > The script generates shader_runner tests that query GL_MATRIX_STRIDE using ARB_program_interface_query's calls but it has not support

Re: [Mesa-dev] [PATCH 6/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

2015-10-02 Thread Ilia Mirkin
On Fri, Oct 2, 2015 at 3:34 AM, Samuel Iglesias Gonsálvez wrote: > On 02/10/15 09:20, Ilia Mirkin wrote: >> I'm a little concerned that your random ssbo packing tests didn't pick >> this up... can you double-check your script? >> > > The script generates shader_runner tests

Re: [Mesa-dev] [PATCH 6/6] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

2015-10-02 Thread Samuel Iglesias Gonsálvez
On 02/10/15 09:39, Ilia Mirkin wrote: > On Fri, Oct 2, 2015 at 3:34 AM, Samuel Iglesias Gonsálvez > wrote: >> On 02/10/15 09:20, Ilia Mirkin wrote: >>> I'm a little concerned that your random ssbo packing tests didn't pick >>> this up... can you double-check your script?