Re: [Mesa-dev] [PATCH 6/6] virgl: use the new parent/child pools for transfers

2016-09-30 Thread Marek Olšák
On Fri, Sep 30, 2016 at 3:00 PM, Nicolai Hähnle wrote: > On 30.09.2016 14:58, Marek Olšák wrote: >> >> For patches 2-6: >> >> Reviewed-by: Marek Olšák > > > Thanks. > >> For patch 1, you'll have to decide whether atomicity is necessary, but >> at least p_atomic_read and p_atomic_set shouldn't be

Re: [Mesa-dev] [PATCH 6/6] virgl: use the new parent/child pools for transfers

2016-09-30 Thread Nicolai Hähnle
On 30.09.2016 14:58, Marek Olšák wrote: For patches 2-6: Reviewed-by: Marek Olšák Thanks. For patch 1, you'll have to decide whether atomicity is necessary, but at least p_atomic_read and p_atomic_set shouldn't be used on intptr_t. I do believe atomicity is necessary. Maybe the right solu

Re: [Mesa-dev] [PATCH 6/6] virgl: use the new parent/child pools for transfers

2016-09-30 Thread Marek Olšák
For patches 2-6: Reviewed-by: Marek Olšák For patch 1, you'll have to decide whether atomicity is necessary, but at least p_atomic_read and p_atomic_set shouldn't be used on intptr_t. Marek On Tue, Sep 27, 2016 at 8:21 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium

[Mesa-dev] [PATCH 6/6] virgl: use the new parent/child pools for transfers

2016-09-27 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/gallium/drivers/virgl/virgl_buffer.c | 4 ++-- src/gallium/drivers/virgl/virgl_context.c | 5 ++--- src/gallium/drivers/virgl/virgl_context.h | 2 +- src/gallium/drivers/virgl/virgl_screen.c | 4 src/gallium/drivers/virgl/virgl_screen.h | 3 +++ src/gallium/d