Re: [Mesa-dev] [PATCH 6/8] dri: Convert driCreateConfigs to use a gl_format enum

2012-10-29 Thread Ian Romanick
On 10/26/2012 11:42 AM, Chad Versace wrote: This is great. I wanted to do this when I last touched intel_screen_make_dri_configs but was unable to find the motivation. I have one suggestion below, but that nit doesn't block the patch. Reviewed-by: Chad Versace + switch (format) { + case

Re: [Mesa-dev] [PATCH 6/8] dri: Convert driCreateConfigs to use a gl_format enum

2012-10-26 Thread Chad Versace
This is great. I wanted to do this when I last touched intel_screen_make_dri_configs but was unable to find the motivation. I have one suggestion below, but that nit doesn't block the patch. Reviewed-by: Chad Versace > + switch (format) { > + case MESA_FORMAT_RGB565: > + masks = masks_

Re: [Mesa-dev] [PATCH 6/8] dri: Convert driCreateConfigs to use a gl_format enum

2012-10-25 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > This is instead of the pair of GLenums for format and type that were > previously used. This is necessary for the Intel drivers to expose sRGB > framebuffer formats. YES! I've wanted to do this for a long time. Series is: Reviewed-by: Eric Anhol

[Mesa-dev] [PATCH 6/8] dri: Convert driCreateConfigs to use a gl_format enum

2012-10-24 Thread Ian Romanick
From: Ian Romanick This is instead of the pair of GLenums for format and type that were previously used. This is necessary for the Intel drivers to expose sRGB framebuffer formats. Signed-off-by: Ian Romanick Cc: Chad Versace --- src/gallium/state_trackers/dri/common/dri_screen.c | 6 +- s