Re: [Mesa-dev] [PATCH 7/7] dri: Reuse dri_message to implement our other message handlers.

2014-01-27 Thread Eric Anholt
Kristian Høgsberg k...@bitplanet.net writes: On Thu, Jan 23, 2014 at 3:12 PM, Eric Anholt e...@anholt.net wrote: Entire series Reviewed-by: Kristian Høgsberg k...@bitplanet.net The only thing that came to mind was that we should move the code to open with O_CLOEXEC to its own wrapper

Re: [Mesa-dev] [PATCH 7/7] dri: Reuse dri_message to implement our other message handlers.

2014-01-26 Thread Kristian Høgsberg
On Thu, Jan 23, 2014 at 3:12 PM, Eric Anholt e...@anholt.net wrote: Entire series Reviewed-by: Kristian Høgsberg k...@bitplanet.net The only thing that came to mind was that we should move the code to open with O_CLOEXEC to its own wrapper function. Of course there's really no reason that

Re: [Mesa-dev] [PATCH 7/7] dri: Reuse dri_message to implement our other message handlers.

2014-01-26 Thread Keith Packard
Eric Anholt e...@anholt.net writes: --- src/glx/dri_common.c | 60 src/glx/dri_common.h | 7 +++--- 2 files changed, 4 insertions(+), 63 deletions(-) (I was going to whinge about the lack of PRINTFLIKE in the previous patch, but then I

[Mesa-dev] [PATCH 7/7] dri: Reuse dri_message to implement our other message handlers.

2014-01-23 Thread Eric Anholt
--- src/glx/dri_common.c | 60 src/glx/dri_common.h | 7 +++--- 2 files changed, 4 insertions(+), 63 deletions(-) diff --git a/src/glx/dri_common.c b/src/glx/dri_common.c index 93c45ea..0dd8982 100644 --- a/src/glx/dri_common.c +++