[Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-19 Thread Marek Olšák
From: Marek Olšák use KILL_IF -1 instead. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 11 -- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 3 -- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c| 42 -- src/gallium/auxiliary/nir/tgsi_to_nir.c

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-19 Thread Roland Scheidegger
For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we don't need neither, so Reviewed-by: Roland Scheidegger 4,6,7, well we can live fine without them, just translating them away the same as you do here too. (I thought some hw could do them natively, hence the driver would have to r

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-20 Thread Marek Olšák
On Sun, Aug 20, 2017 at 4:29 AM, Roland Scheidegger wrote: > For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we > don't need neither, so > Reviewed-by: Roland Scheidegger > > 4,6,7, well we can live fine without them, just translating them away > the same as you do here too. (I t

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-20 Thread Ilia Mirkin
On Sun, Aug 20, 2017 at 6:51 AM, Marek Olšák wrote: > On Sun, Aug 20, 2017 at 4:29 AM, Roland Scheidegger > wrote: >> For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we >> don't need neither, so >> Reviewed-by: Roland Scheidegger >> >> 4,6,7, well we can live fine without them,

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-21 Thread Emil Velikov
Hi Marek, On 20 August 2017 at 01:49, Marek Olšák wrote: > From: Marek Olšák > > use KILL_IF -1 instead. > --- I'm not 100% sure, but I believe virgl uses TGSI to talk with the host driver. Thus Dave might want to check if the series does not break things on his end. Alongside the drop of old o

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-21 Thread Marek Olšák
On Mon, Aug 21, 2017 at 12:47 PM, Emil Velikov wrote: > Hi Marek, > > On 20 August 2017 at 01:49, Marek Olšák wrote: >> From: Marek Olšák >> >> use KILL_IF -1 instead. >> --- > I'm not 100% sure, but I believe virgl uses TGSI to talk with the host driver. > Thus Dave might want to check if the s

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-21 Thread Emil Velikov
On 21 August 2017 at 14:19, Marek Olšák wrote: > On Mon, Aug 21, 2017 at 12:47 PM, Emil Velikov > wrote: >> Hi Marek, >> >> On 20 August 2017 at 01:49, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> use KILL_IF -1 instead. >>> --- >> I'm not 100% sure, but I believe virgl uses TGSI to talk w

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-21 Thread Dave Airlie
On 21 August 2017 at 23:44, Emil Velikov wrote: > On 21 August 2017 at 14:19, Marek Olšák wrote: >> On Mon, Aug 21, 2017 at 12:47 PM, Emil Velikov >> wrote: >>> Hi Marek, >>> >>> On 20 August 2017 at 01:49, Marek Olšák wrote: From: Marek Olšák use KILL_IF -1 instead. --- >

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-21 Thread Marek Olšák
On Sun, Aug 20, 2017 at 4:29 AM, Roland Scheidegger wrote: > For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we > don't need neither, so > Reviewed-by: Roland Scheidegger > > 4,6,7, well we can live fine without them, just translating them away > the same as you do here too. (I t

Re: [Mesa-dev] [PATCH 8/8] gallium: remove TGSI opcode KILL

2017-08-21 Thread Roland Scheidegger
Am 21.08.2017 um 22:57 schrieb Marek Olšák: > On Sun, Aug 20, 2017 at 4:29 AM, Roland Scheidegger > wrote: >> For 1-3/8, I don't think anything ever used these, and 5/8 (DPH) we >> don't need neither, so >> Reviewed-by: Roland Scheidegger >> >> 4,6,7, well we can live fine without them, just tra