Re: [Mesa-dev] [PATCH 8/8] mesa: simplify _mesa_update_draw_buffers()

2014-08-19 Thread Olivier Galibert
Hi, That patch makes glDrawBuffer(0, NULL); segfault because _mesa_drawbuffers expects buffers[0] to be valid. Note that the bug is there, but I'm not sure what the final setup should look like in that case. Best, OG. PS: reported by haagch on irc On Fri, Aug 8, 2014 at 11:20 PM, Brian

[Mesa-dev] [PATCH 8/8] mesa: simplify _mesa_update_draw_buffers()

2014-08-08 Thread Brian Paul
There's no need to copy the array of DrawBuffer enums to a temp array. --- src/mesa/main/buffers.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index 6b4fac9..140cf6e 100644 --- a/src/mesa/main/buffers.c +++

Re: [Mesa-dev] [PATCH 8/8] mesa: simplify _mesa_update_draw_buffers()

2014-08-08 Thread Roland Scheidegger
Am 08.08.2014 23:20, schrieb Brian Paul: There's no need to copy the array of DrawBuffer enums to a temp array. --- src/mesa/main/buffers.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index