Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-19 Thread Chris Forbes
OK, I'll go back to allowing zero. It's silly but harmless. On Wed, Nov 20, 2013 at 8:29 AM, Ian Romanick wrote: > On 11/09/2013 01:02 AM, Chris Forbes wrote: >> Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. >> >> V3: - Disallow primcount==0 for DrawMulti*Indirect. Th

Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-19 Thread Ian Romanick
On 11/09/2013 01:02 AM, Chris Forbes wrote: > Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. > > V3: - Disallow primcount==0 for DrawMulti*Indirect. The extension spec > contradicts itself on this, but the GL4.3 spec disallows it. > > - Make it clear that the

Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-19 Thread Ian Romanick
On 11/12/2013 12:13 PM, Kenneth Graunke wrote: > On 11/09/2013 01:02 AM, Chris Forbes wrote: >> Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. >> >> V3: - Disallow primcount==0 for DrawMulti*Indirect. The extension spec >> contradicts itself on this, but the GL4.3

Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-15 Thread Chris Forbes
Ken, I don't have access to another implementation at the moment -- can you test? -- Chris On Wed, Nov 13, 2013 at 9:57 AM, Kenneth Graunke wrote: > On 11/12/2013 12:35 PM, Paul Berry wrote: >> On 12 November 2013 12:13, Kenneth Graunke > > wrote: >> >> It woul

Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-12 Thread Kenneth Graunke
On 11/12/2013 12:35 PM, Paul Berry wrote: > On 12 November 2013 12:13, Kenneth Graunke > wrote: > > It would be great to put a citation for this: > > /* From the ARB_multi_draw_indirect specification: > * "INVALID_VALUE is generated by MultiDrawArraysIn

Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-12 Thread Paul Berry
On 12 November 2013 12:13, Kenneth Graunke wrote: > It would be great to put a citation for this: > > /* From the ARB_multi_draw_indirect specification: > * "INVALID_VALUE is generated by MultiDrawArraysIndirect or > * MultiDrawElementsIndirect if is negative." > * > * " must be positive, o

Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-12 Thread Kenneth Graunke
On 11/09/2013 01:02 AM, Chris Forbes wrote: > Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. > > V3: - Disallow primcount==0 for DrawMulti*Indirect. The extension spec > contradicts itself on this, but the GL4.3 spec disallows it. > > - Make it clear that the

[Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-09 Thread Chris Forbes
Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. V3: - Disallow primcount==0 for DrawMulti*Indirect. The extension spec contradicts itself on this, but the GL4.3 spec disallows it. - Make it clear that the caller has dealt with stride==0 Signed-off-by: Chris F