Re: [Mesa-dev] [PATCH mesa] egl/wayland: check for invalid format index

2018-02-15 Thread Eric Engestrom
On Thursday, 2018-02-15 11:25:33 +, Daniel Stone wrote: > Hi Eric, > > On 15 February 2018 at 11:17, Eric Engestrom > wrote: > > Daniel, `w` seemed like the "least bad" thing to return in this case; > > would you prefer `0`? > > I guess Coverity doesn't know it can never be invalid. We look

Re: [Mesa-dev] [PATCH mesa] egl/wayland: check for invalid format index

2018-02-15 Thread Daniel Stone
Hi Eric, On 15 February 2018 at 11:17, Eric Engestrom wrote: > Daniel, `w` seemed like the "least bad" thing to return in this case; > would you prefer `0`? I guess Coverity doesn't know it can never be invalid. We look up a visual in the table using dri2_surf->format, whcih is only ever set fro

[Mesa-dev] [PATCH mesa] egl/wayland: check for invalid format index

2018-02-15 Thread Eric Engestrom
CID: 1429516 Fixes: d32b23f3830099a328b91 "egl/wayland: Add bpp to visual map" Cc: Daniel Stone Signed-off-by: Eric Engestrom --- Daniel, `w` seemed like the "least bad" thing to return in this case; would you prefer `0`? --- src/egl/drivers/dri2/platform_wayland.c | 5 + 1 file changed, 5 i