Re: [Mesa-dev] [PATCH mesa] egl: add helper to combine two u32 into one u64

2018-08-21 Thread Emil Velikov
On 18 August 2018 at 13:57, Eric Engestrom wrote: > The original issue spotted was an upcast done after a bitwise ops, but > since the same logic is done in multiple place, Emil suggested adding > a helper to avoid mistakes. > Thank you. > Signed-off-by: Eric Engestrom > --- > src/egl/drivers/d

Re: [Mesa-dev] [PATCH mesa] egl: add helper to combine two u32 into one u64

2018-08-21 Thread Daniel Stone
Hi Eric, On Sat, 18 Aug 2018 at 13:58, Eric Engestrom wrote: > The original issue spotted was an upcast done after a bitwise ops, but > since the same logic is done in multiple place, Emil suggested adding > a helper to avoid mistakes. Works for me. The original issue we had was not so much with

[Mesa-dev] [PATCH mesa] egl: add helper to combine two u32 into one u64

2018-08-18 Thread Eric Engestrom
The original issue spotted was an upcast done after a bitwise ops, but since the same logic is done in multiple place, Emil suggested adding a helper to avoid mistakes. Signed-off-by: Eric Engestrom --- src/egl/drivers/dri2/egl_dri2.c | 4 ++-- src/egl/drivers/dri2/egl_dri2.h | 6