Re: [Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

2018-06-15 Thread Jeremy Sequoia
Sent from my iPhone... > On Jun 15, 2018, at 09:35, Eric Engestrom wrote: > >> On Friday, 2018-06-15 08:14:40 -0700, Jeremy Huddleston Sequoia wrote: >> I think we can instead revert c7f3657450683827446072ad6b1e8fce04078162. > > If you think the issue is resolved, then please feel free to sen

Re: [Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

2018-06-15 Thread Eric Engestrom
On Friday, 2018-06-15 08:14:40 -0700, Jeremy Huddleston Sequoia wrote: > I think we can instead revert c7f3657450683827446072ad6b1e8fce04078162. If you think the issue is resolved, then please feel free to send that revert :) Is there a way for someone without a Mac to test this? > I believe the

Re: [Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

2018-06-15 Thread Jeremy Huddleston Sequoia
I think we can instead revert c7f3657450683827446072ad6b1e8fce04078162. I believe the underlying issue should instead be addressed by a087a09fa86f9617af98f6294dd2228555a4891c. If any issues remain, we should address them properly rather than masking them with this. A quick audit makes me susp

Re: [Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

2018-06-15 Thread Jon Turney
On 12/06/2018 16:53, Dylan Baker wrote: Quoting Eric Engestrom (2018-06-12 04:25:10) Copied from configure.ac:1950 Signed-off-by: Eric Engestrom --- Is it still needed? We've been building on MacOS for a while, yet nobody noticed anything (Dylan?) If not, we should probably avoid unnecessary d

Re: [Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

2018-06-12 Thread Dylan Baker
Quoting Eric Engestrom (2018-06-12 04:25:10) > Copied from configure.ac:1950 > > Signed-off-by: Eric Engestrom > --- > Is it still needed? We've been building on MacOS for a while, > yet nobody noticed anything (Dylan?) > If not, we should probably avoid unnecessary differences with Khronos' > he

[Mesa-dev] [PATCH mesa] meson: add GL/glext.h warning fix for MacOS

2018-06-12 Thread Eric Engestrom
Copied from configure.ac:1950 Signed-off-by: Eric Engestrom --- Is it still needed? We've been building on MacOS for a while, yet nobody noticed anything (Dylan?) If not, we should probably avoid unnecessary differences with Khronos' headers and nuke BUILDING_MESA. --- meson.build | 1 + 1 file