Re: [Mesa-dev] [PATCH mesa] spirv: add missing include path

2017-07-19 Thread Eric Engestrom
On Tuesday, 2017-07-18 15:32:27 -0700, Kenneth Graunke wrote: > On Tuesday, July 18, 2017 11:16:50 AM PDT Emil Velikov wrote: > > On 18 July 2017 at 19:03, Eric Engestrom wrote: > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101831 > > > Signed-off-by:

Re: [Mesa-dev] [PATCH mesa] spirv: add missing include path

2017-07-18 Thread Kenneth Graunke
On Tuesday, July 18, 2017 11:16:50 AM PDT Emil Velikov wrote: > On 18 July 2017 at 19:03, Eric Engestrom wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101831 > > Signed-off-by: Eric Engestrom > > --- > > > > Note: Android

Re: [Mesa-dev] [PATCH mesa] spirv: add missing include path

2017-07-18 Thread Jason Ekstrand
On Tue, Jul 18, 2017 at 11:15 AM, Ian Romanick wrote: > I can believe the fix, but I don't understand why it's necessary. > spirv_info.c includes spriv_info.h in the same manner as before > 2dd4e2ec, and, as far as I can understand, spirv_info.c gets built in > the same way

Re: [Mesa-dev] [PATCH mesa] spirv: add missing include path

2017-07-18 Thread Emil Velikov
On 18 July 2017 at 19:03, Eric Engestrom wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101831 > Signed-off-by: Eric Engestrom > --- > > Note: Android and SCons probably need a similar fix > --- >

Re: [Mesa-dev] [PATCH mesa] spirv: add missing include path

2017-07-18 Thread Ian Romanick
I can believe the fix, but I don't understand why it's necessary. spirv_info.c includes spriv_info.h in the same manner as before 2dd4e2ec, and, as far as I can understand, spirv_info.c gets built in the same way as before. Can someone explain to me why it broke? ...because I don't want to break

[Mesa-dev] [PATCH mesa] spirv: add missing include path

2017-07-18 Thread Eric Engestrom
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101831 Signed-off-by: Eric Engestrom --- Note: Android and SCons probably need a similar fix --- src/compiler/Makefile.nir.am | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/compiler/Makefile.nir.am