Re: [Mesa-dev] [PATCH mesa] util: remove unnecessary random whitespaces

2018-10-25 Thread Eric Anholt
Ian Romanick writes: > On 10/25/2018 05:13 AM, Eric Engestrom wrote: >> On Thursday, 2018-10-25 17:54:16 +1100, Timothy Arceri wrote: >>> On 25/10/18 7:42 am, Ian Romanick wrote: On 10/23/2018 04:15 AM, Eric Engestrom wrote: > Suggested-by: Timothy Arceri >>> >>> Um no :P I suggested

Re: [Mesa-dev] [PATCH mesa] util: remove unnecessary random whitespaces

2018-10-25 Thread Ian Romanick
On 10/25/2018 05:13 AM, Eric Engestrom wrote: > On Thursday, 2018-10-25 17:54:16 +1100, Timothy Arceri wrote: >> On 25/10/18 7:42 am, Ian Romanick wrote: >>> On 10/23/2018 04:15 AM, Eric Engestrom wrote: Suggested-by: Timothy Arceri >> >> Um no :P I suggested you fix the formatting in your

Re: [Mesa-dev] [PATCH mesa] util: remove unnecessary random whitespaces

2018-10-25 Thread Eric Engestrom
On Thursday, 2018-10-25 17:54:16 +1100, Timothy Arceri wrote: > On 25/10/18 7:42 am, Ian Romanick wrote: > > On 10/23/2018 04:15 AM, Eric Engestrom wrote: > > > Suggested-by: Timothy Arceri > > Um no :P I suggested you fix the formatting in your patch to match the Mesa > style. Right, sorry,

Re: [Mesa-dev] [PATCH mesa] util: remove unnecessary random whitespaces

2018-10-25 Thread Timothy Arceri
On 25/10/18 7:42 am, Ian Romanick wrote: On 10/23/2018 04:15 AM, Eric Engestrom wrote: Suggested-by: Timothy Arceri Um no :P I suggested you fix the formatting in your patch to match the Mesa style. Signed-off-by: Eric Engestrom --- Timothy, I opted to remove them all instead of adding

Re: [Mesa-dev] [PATCH mesa] util: remove unnecessary random whitespaces

2018-10-24 Thread Ian Romanick
On 10/23/2018 04:15 AM, Eric Engestrom wrote: > Suggested-by: Timothy Arceri > Signed-off-by: Eric Engestrom > --- > Timothy, I opted to remove them all instead of adding even more, as it > would break again next time something changes (the set_foreach() one was > already broken before my patch

[Mesa-dev] [PATCH mesa] util: remove unnecessary random whitespaces

2018-10-23 Thread Eric Engestrom
Suggested-by: Timothy Arceri Signed-off-by: Eric Engestrom --- Timothy, I opted to remove them all instead of adding even more, as it would break again next time something changes (the set_foreach() one was already broken before my patch for instance) and result in lots of unnecessary churn for