[Mesa-dev] [PATCH mesa] vulkan/wsi_common_display: Return SURFACE_LOST for fatal DRM errors

2018-06-26 Thread Keith Packard
Instead of encouraging the client to re-create the swapchain and keep going with an OUT_OF_DATE error, tell the client that further use of the current surface will not succeed as the associated kernel objects are no longer valid. In particular, when a DRM lease is revoked, then the client needs to

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi_common_display: Return SURFACE_LOST for fatal DRM errors

2018-06-27 Thread Jason Ekstrand
Is this the same thing that happens on VT switch? If so, we may want to return SURFACE_LOST for leases and OUT_OF_DATE for things running directly on the display. --Jason On Tue, Jun 26, 2018 at 4:23 PM, Keith Packard wrote: > Instead of encouraging the client to re-create the swapchain and ke

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi_common_display: Return SURFACE_LOST for fatal DRM errors

2018-06-27 Thread Keith Packard
Jason Ekstrand writes: > Is this the same thing that happens on VT switch? If so, we may want to > return SURFACE_LOST for leases and OUT_OF_DATE for things running directly > on the display. No, on VT switch, my code currently sits in the driver and waits for the VT to return. The errors here

Re: [Mesa-dev] [PATCH mesa] vulkan/wsi_common_display: Return SURFACE_LOST for fatal DRM errors

2018-06-27 Thread Jason Ekstrand
Sounds fine to me. I just wanted to confirm that they are unrecoverable. Reviewed-by: Jason Ekstrand On Wed, Jun 27, 2018 at 9:13 AM, Keith Packard wrote: > Jason Ekstrand writes: > > > Is this the same thing that happens on VT switch? If so, we may want to > > return SURFACE_LOST for lease