Re: [Mesa-dev] [PATCH mesa 1/2] meson: standardize .so version to major.minor.patch

2017-11-06 Thread Dylan Baker
To clarify, with the one hunk in patch 2 moved to patch 1, both patches are: Reviewed-by: Dylan Baker Quoting Dylan Baker (2017-11-02 16:51:18) > I'm also not sure that it matters, but I think consistency with autotools is > important, > Reviewed-by: Dylan Baker > > Quoting Eric Engestrom (2017

Re: [Mesa-dev] [PATCH mesa 1/2] meson: standardize .so version to major.minor.patch

2017-11-02 Thread Dylan Baker
I'm also not sure that it matters, but I think consistency with autotools is important, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-11-02 16:42:11) > This `version` field defines the filename for the .so. > The plan .so as well as .so.$major are always symlinks to this. > > Unless I'm

[Mesa-dev] [PATCH mesa 1/2] meson: standardize .so version to major.minor.patch

2017-11-02 Thread Eric Engestrom
This `version` field defines the filename for the .so. The plan .so as well as .so.$major are always symlinks to this. Unless I'm mistaken, only the major is ever used, so this shouldn't, but for consistency with autotools (and in case it does matter), let's always have all 3 major.minor.patch com