yeah, you are right, overlooked that "Target target;" inside the inner
"tex" struct.
On Sat, Sep 22, 2018 at 4:27 PM, Jan Vesely wrote:
> The warning is correct. In the first case, memset tries to zero "Target"
> object which has a non-trivial constructor and non-trivial copy-constructor.
> The
On Saturday, 2018-09-22 10:27:50 -0400, Jan Vesely wrote:
> The warning is correct. In the first case, memset tries to zero "Target"
> object which has a non-trivial constructor and non-trivial
> copy-constructor. The original code is broken in the way it mixes C and C++
> initialization and the
The warning is correct. In the first case, memset tries to zero "Target"
object which has a non-trivial constructor and non-trivial
copy-constructor. The original code is broken in the way it mixes C and C++
initialization and the patch only papers over the issue.
The correct fix would be to
yeah, I agree here. Either the code was wrong in the first place,
which means it would have to be fixed properly or the warning is
wrong. The proper fix here is that GCC should detect itself if it's
safe to do or not, otherwise that warning becomes a "might be a
problem" thing which doesn't help
Based on the various fixes, warning seems bogus -- is the proper
solution -Wno-class-memaccess? (Or however one disables such
things...)
On Fri, Sep 21, 2018 at 9:50 AM, Eric Engestrom
wrote:
> Signed-off-by: Eric Engestrom
> ---
> src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 2 +-
Signed-off-by: Eric Engestrom
---
src/gallium/drivers/nouveau/codegen/nv50_ir.cpp| 2 +-
src/gallium/drivers/nouveau/codegen/nv50_ir_target.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir.cpp
