Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-14 Thread Jason Ekstrand
On Thu, Jun 14, 2018 at 11:42 AM, Keith Packard wrote: > Jason Ekstrand writes: > > >> + if (instance->enabled_extensions.KHR_display) { > >> + master_fd = open(path, O_RDWR | O_CLOEXEC); > >> > > > > Is this supposed to be opening primary_path instead? > > Yes, and this section of code

Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-14 Thread Keith Packard
Jason Ekstrand writes: >> Signed-off-by: Keith Packard >> >> fixup >> > > Did you mean to leave this in here? Nope; just rebasing/squashing noise. I noticed this in passing and have already removed it. -- -keith signature.asc Description: PGP signature

Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-14 Thread Keith Packard
Jason Ekstrand writes: >> + if (instance->enabled_extensions.KHR_display) { >> + master_fd = open(path, O_RDWR | O_CLOEXEC); >> > > Is this supposed to be opening primary_path instead? Yes, and this section of code needs to occur before anv_init_wsi. I appear to have skipped testing

Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-13 Thread Jason Ekstrand
On Mon, Jun 11, 2018 at 10:39 PM, Keith Packard wrote: > This adds support for the KHR_display extension to the anv Vulkan > driver. The driver now attempts to open the master DRM node when the > KHR_display extension is requested so that the common winsys code can > perform the necessary

Re: [Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-13 Thread Jason Ekstrand
On Mon, Jun 11, 2018 at 10:39 PM, Keith Packard wrote: > This adds support for the KHR_display extension to the anv Vulkan > driver. The driver now attempts to open the master DRM node when the > KHR_display extension is requested so that the common winsys code can > perform the necessary

[Mesa-dev] [PATCH mesa 2/9] anv: Add KHR_display extension to anv [v5]

2018-06-11 Thread Keith Packard
This adds support for the KHR_display extension to the anv Vulkan driver. The driver now attempts to open the master DRM node when the KHR_display extension is requested so that the common winsys code can perform the necessary operations. v2: Make sure primary fd is usable When