Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-26 Thread Jose Fonseca
On 26/09/17 12:20, Ilia Mirkin wrote: On Tue, Sep 26, 2017 at 7:07 AM, Jose Fonseca wrote: On 25/09/17 14:30, Eric Engestrom wrote: I pushed the rest of the series. See below for discussion on this patch. On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote: On 19/09/17 15:14, Eric

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-26 Thread Ilia Mirkin
On Tue, Sep 26, 2017 at 7:07 AM, Jose Fonseca wrote: > On 25/09/17 14:30, Eric Engestrom wrote: >> >> I pushed the rest of the series. >> See below for discussion on this patch. >> >> >> On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote: >>> >>> On 19/09/17 15:14, Eric Engestrom wrote: >

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-26 Thread Jose Fonseca
On 25/09/17 14:30, Eric Engestrom wrote: I pushed the rest of the series. See below for discussion on this patch. On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote: On 19/09/17 15:14, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- scons/custom.py | 2 +- 1 file change

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-25 Thread Eric Engestrom
I pushed the rest of the series. See below for discussion on this patch. On Wednesday, 2017-09-20 17:05:21 +, Jose Fonseca wrote: > On 19/09/17 15:14, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > scons/custom.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-20 Thread Jose Fonseca
On 19/09/17 15:14, Eric Engestrom wrote: Signed-off-by: Eric Engestrom --- scons/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/custom.py b/scons/custom.py index 0767ba936d410167116d..978ee5f9ec7c23a74cb9 100644 --- a/scons/custom.py +++ b/scons/custom.py

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-19 Thread Eric Engestrom
On Tuesday, 2017-09-19 10:20:34 -0400, Ilia Mirkin wrote: > This might be python3-compatible, but it's not the same thing. str != > unicode. Not sure where "names" can come from, but if it can come in > as a unicode string, this won't work. Thanks, this was the patch I was the least-sure about. Dr

Re: [Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-19 Thread Ilia Mirkin
This might be python3-compatible, but it's not the same thing. str != unicode. Not sure where "names" can come from, but if it can come in as a unicode string, this won't work. On Tue, Sep 19, 2017 at 10:14 AM, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > scons/custom.py | 2 +-

[Mesa-dev] [PATCH mesa 6/6] scons: use python3-compatible string-check

2017-09-19 Thread Eric Engestrom
Signed-off-by: Eric Engestrom --- scons/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/custom.py b/scons/custom.py index 0767ba936d410167116d..978ee5f9ec7c23a74cb9 100644 --- a/scons/custom.py +++ b/scons/custom.py @@ -257,7 +257,7 @@ def parse_source_list(env