Re: [Mesa-dev] [PATCH mesa v2 2/2] meson: bring MESA_GIT_SHA1 in line with other build systems

2017-10-26 Thread Dylan Baker
one small nit, otherwise, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2017-10-26 08:40:57) > From: Eric Engestrom > > Meson's vcs_tag() uses the output of `git describe`, eg. > 17.3-branchpoint-5-gfbf29c3cd15ae831e249+ > > Whereas the other build

[Mesa-dev] [PATCH mesa v2 2/2] meson: bring MESA_GIT_SHA1 in line with other build systems

2017-10-26 Thread Eric Engestrom
From: Eric Engestrom Meson's vcs_tag() uses the output of `git describe`, eg. 17.3-branchpoint-5-gfbf29c3cd15ae831e249+ Whereas the other build systems used a script that outputs only the sha1 of the HEAD commit, eg. fbf29c3cd1 Given that this information is used by