Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Jason Ekstrand
On Tue, May 2, 2017 at 8:55 AM, Rafael Antognolli < rafael.antogno...@intel.com> wrote: > On Tue, May 02, 2017 at 08:44:05AM -0700, Jason Ekstrand wrote: > > On Tue, May 2, 2017 at 8:28 AM, Rafael Antognolli < > rafael.antogno...@intel.com> > > wrote: > > > > On Tue, May 02, 2017 at

Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Rafael Antognolli
On Tue, May 02, 2017 at 08:44:05AM -0700, Jason Ekstrand wrote: > On Tue, May 2, 2017 at 8:28 AM, Rafael Antognolli > > wrote: > > On Tue, May 02, 2017 at 07:26:53AM -0700, Jason Ekstrand wrote: > > On Mon, May 1, 2017 at 6:43 PM, Rafael Antognolli < >

Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Jason Ekstrand
On Tue, May 2, 2017 at 8:28 AM, Rafael Antognolli < rafael.antogno...@intel.com> wrote: > On Tue, May 02, 2017 at 07:26:53AM -0700, Jason Ekstrand wrote: > > On Mon, May 1, 2017 at 6:43 PM, Rafael Antognolli < > rafael.antogno...@intel.com> > > wrote: > > > > We need to use some enums inside

Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Rafael Antognolli
On Tue, May 02, 2017 at 07:26:53AM -0700, Jason Ekstrand wrote: > On Mon, May 1, 2017 at 6:43 PM, Rafael Antognolli > > wrote: > > We need to use some enums inside genX_state_upload.c, but including the > whole header will cause several conflicts between

Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Jason Ekstrand
On Mon, May 1, 2017 at 6:43 PM, Rafael Antognolli < rafael.antogno...@intel.com> wrote: > We need to use some enums inside genX_state_upload.c, but including the > whole header will cause several conflicts between things defined in this > header and the genxml auto-generated headers. > > So

Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Rafael Antognolli
On Tue, May 02, 2017 at 09:38:53AM +0100, Emil Velikov wrote: > On 2 May 2017 at 09:32, Emil Velikov wrote: > > Hi Rafael, > > > > On 2 May 2017 at 02:43, Rafael Antognolli > > wrote: > >> We need to use some enums inside

Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Emil Velikov
On 2 May 2017 at 09:32, Emil Velikov wrote: > Hi Rafael, > > On 2 May 2017 at 02:43, Rafael Antognolli wrote: >> We need to use some enums inside genX_state_upload.c, but including the >> whole header will cause several conflicts between

Re: [Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-02 Thread Emil Velikov
Hi Rafael, On 2 May 2017 at 02:43, Rafael Antognolli wrote: > We need to use some enums inside genX_state_upload.c, but including the > whole header will cause several conflicts between things defined in this > header and the genxml auto-generated headers. > > So

[Mesa-dev] [PATCH v03 12/38] i965: Split out enum from brw_eu_defines.h

2017-05-01 Thread Rafael Antognolli
We need to use some enums inside genX_state_upload.c, but including the whole header will cause several conflicts between things defined in this header and the genxml auto-generated headers. So create a separate header that is included both by brw_eu_defines.h and genX_state_upload.c.