Re: [Mesa-dev] [PATCH v03 14/38] i965: Move MOCS macros to brw_context.h.

2017-05-04 Thread Rafael Antognolli
On Wed, May 03, 2017 at 11:36:29PM -0700, Kenneth Graunke wrote: > On Wednesday, May 3, 2017 7:52:01 PM PDT Pohjolainen, Topi wrote: > > On Wed, May 03, 2017 at 05:11:45PM -0700, Rafael Antognolli wrote: > > > On Wed, May 03, 2017 at 08:28:24PM +0300, Pohjolainen, Topi wrote: > > > > On Mon, May

Re: [Mesa-dev] [PATCH v03 14/38] i965: Move MOCS macros to brw_context.h.

2017-05-04 Thread Kenneth Graunke
On Wednesday, May 3, 2017 7:52:01 PM PDT Pohjolainen, Topi wrote: > On Wed, May 03, 2017 at 05:11:45PM -0700, Rafael Antognolli wrote: > > On Wed, May 03, 2017 at 08:28:24PM +0300, Pohjolainen, Topi wrote: > > > On Mon, May 01, 2017 at 06:43:02PM -0700, Rafael Antognolli wrote: > > > > These

Re: [Mesa-dev] [PATCH v03 14/38] i965: Move MOCS macros to brw_context.h.

2017-05-03 Thread Pohjolainen, Topi
On Wed, May 03, 2017 at 05:11:45PM -0700, Rafael Antognolli wrote: > On Wed, May 03, 2017 at 08:28:24PM +0300, Pohjolainen, Topi wrote: > > On Mon, May 01, 2017 at 06:43:02PM -0700, Rafael Antognolli wrote: > > > These macros are defined in brw_defines.h, which contains a lot of > > > macros that

Re: [Mesa-dev] [PATCH v03 14/38] i965: Move MOCS macros to brw_context.h.

2017-05-03 Thread Rafael Antognolli
On Wed, May 03, 2017 at 08:28:24PM +0300, Pohjolainen, Topi wrote: > On Mon, May 01, 2017 at 06:43:02PM -0700, Rafael Antognolli wrote: > > These macros are defined in brw_defines.h, which contains a lot of > > macros that conflict with autogenerated code from genxml. But we need to > > use them

Re: [Mesa-dev] [PATCH v03 14/38] i965: Move MOCS macros to brw_context.h.

2017-05-03 Thread Pohjolainen, Topi
On Mon, May 01, 2017 at 06:43:02PM -0700, Rafael Antognolli wrote: > These macros are defined in brw_defines.h, which contains a lot of > macros that conflict with autogenerated code from genxml. But we need to > use them (the MOCS macros) in some of that same genxml code. > > Moving them to

[Mesa-dev] [PATCH v03 14/38] i965: Move MOCS macros to brw_context.h.

2017-05-01 Thread Rafael Antognolli
These macros are defined in brw_defines.h, which contains a lot of macros that conflict with autogenerated code from genxml. But we need to use them (the MOCS macros) in some of that same genxml code. Moving them to brw_context.h solves that problem and we don't have to include brw_defines.h.