Re: [Mesa-dev] [PATCH v10 06/20] clover/api: Rework the validation of devices for building

2019-01-20 Thread Pierre Moreau
Thank you for the review. Do you think you’ll have the opportunity to have a look at patches 13 and 16? (Patch 15 is also missing a review, but I found some improvements to be made there.) Thanks, Pierre On 2019-01-18 — 15:52, Francisco Jerez wrote: > Pierre Moreau writes: > > > Reviewed-by:

Re: [Mesa-dev] [PATCH v10 06/20] clover/api: Rework the validation of devices for building

2019-01-18 Thread Francisco Jerez
Pierre Moreau writes: > Reviewed-by: Francisco Jerez > > Changes since: > * v5: > - Drop the `valid_devs` argument to `validate_build_common()` > (Francisco Jerez) > - Change `clLinkProgram()` to initialise `prog`’s devices prior to > calling `validate_build_common()`. > * v2: > -

[Mesa-dev] [PATCH v10 06/20] clover/api: Rework the validation of devices for building

2019-01-08 Thread Pierre Moreau
Reviewed-by: Francisco Jerez Changes since: * v5: - Drop the `valid_devs` argument to `validate_build_common()` (Francisco Jerez) - Change `clLinkProgram()` to initialise `prog`’s devices prior to calling `validate_build_common()`. * v2: - validate_build_common no longer returns a