Re: [Mesa-dev] [PATCH v14 15/36] i965: Improve same-buffer restriction for imports

2017-06-05 Thread Jason Ekstrand
On June 5, 2017 6:10:22 PM Varad Gautam wrote: Hi Daniel, On Mon, 2017-06-05 at 14:53 +0100, Daniel Stone wrote: Hi Varad, On 30 May 2017 at 12:53, Varad Gautam wrote: > > +   /* We only support all planes from the same bo. > +* brw_bo_gem_create_from_prime() should return the same poin

Re: [Mesa-dev] [PATCH v14 15/36] i965: Improve same-buffer restriction for imports

2017-06-05 Thread Varad Gautam
Hi Daniel, On Mon, 2017-06-05 at 14:53 +0100, Daniel Stone wrote: > Hi Varad, > > On 30 May 2017 at 12:53, Varad Gautam wrote: > > > > +   /* We only support all planes from the same bo. > > +* brw_bo_gem_create_from_prime() should return the same pointer for all > > +* fds received her

Re: [Mesa-dev] [PATCH v14 15/36] i965: Improve same-buffer restriction for imports

2017-06-05 Thread Daniel Stone
Hi Varad, On 5 June 2017 at 15:13, Varad Gautam wrote: > On Mon, 2017-06-05 at 14:53 +0100, Daniel Stone wrote: >> This above takes a ref, which gets leaked. >> >>struct brw_bo *aux = >> brw_bo_gem_create_from_prime(screen->bufmgr, fds[i], size); >>brw_bo_unreference(aux);

Re: [Mesa-dev] [PATCH v14 15/36] i965: Improve same-buffer restriction for imports

2017-06-05 Thread Daniel Stone
Hi Varad, On 30 May 2017 at 12:53, Varad Gautam wrote: > + /* We only support all planes from the same bo. > +* brw_bo_gem_create_from_prime() should return the same pointer for all > +* fds received here */ > + bo = brw_bo_gem_create_from_prime(screen->bufmgr, fds[0], size); > + fo

[Mesa-dev] [PATCH v14 15/36] i965: Improve same-buffer restriction for imports

2017-05-30 Thread Varad Gautam
From: Daniel Stone Intel hardware requires that all planes of an image come from the same buffer, which is currently implemented by testing that all FDs are numerically the same. However, when going through a winsys (e.g.) or anything which transits FDs individually, the FDs may be different eve